Castro icon indicating copy to clipboard operation
Castro copied to clipboard
verified publisher icon AMReX-Astro

add P_theta flux register and scale pressure using area and volume

Open zhichen3 opened this issue 1 year ago • 2 comments

PR summary

This pr adds P_theta flux similar to P_radial for spherical 2d. This addresses issue #2927

PR motivation

PR checklist

  • [ ] test suite needs to be run on this PR
  • [ ] this PR will change answers in the test suite to more than roundoff level
  • [ ] all newly-added functions have docstrings as per the coding conventions
  • [ ] the CHANGES file has been updated, if appropriate
  • [ ] if appropriate, this change is described in the docs

zhichen3 avatar Sep 16 '24 17:09 zhichen3

this might be related: https://github.com/AMReX-Astro/Castro/issues/2803

zingale avatar Sep 16 '24 17:09 zingale

I think this is fine too. I just copied what's there for P_radial and added a corresponding version for P_theta.

zhichen3 avatar Sep 19 '24 01:09 zhichen3