Castro icon indicating copy to clipboard operation
Castro copied to clipboard

[WIP] loosen nse constraint only after max subcycle is reached

Open zhichen3 opened this issue 2 years ago • 2 comments

PR summary

PR motivation

PR checklist

  • [ ] test suite needs to be run on this PR
  • [ ] this PR will change answers in the test suite to more than roundoff level
  • [ ] all newly-added functions have docstrings as per the coding conventions
  • [ ] the CHANGES file has been updated, if appropriate
  • [ ] if appropriate, this change is described in the docs

zhichen3 avatar May 02 '23 16:05 zhichen3

do we still want to consider this?

zingale avatar Jul 26 '24 16:07 zingale

I think its a reasonable thing to do if we were to use these loosen-constraint parameters. But right now I tend to not use them because I think it would make the constraint "too loose".

zhichen3 avatar Jul 27 '24 03:07 zhichen3