AMICI icon indicating copy to clipboard operation
AMICI copied to clipboard

Add gradient checks for SBML test suite

Open dilpath opened this issue 2 years ago • 4 comments

dilpath avatar May 16 '23 17:05 dilpath

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.49%. Comparing base (b4ab8a2) to head (179be29).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2093      +/-   ##
===========================================
- Coverage    77.88%   76.49%   -1.40%     
===========================================
  Files          322      317       -5     
  Lines        20678    20523     -155     
  Branches      1440     1438       -2     
===========================================
- Hits         16105    15699     -406     
- Misses        4570     4820     +250     
- Partials         3        4       +1     
Flag Coverage Δ
cpp 73.67% <ø> (ø)
cpp_python 34.35% <ø> (ø)
petab ?
python 72.48% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

codecov[bot] avatar May 16 '23 22:05 codecov[bot]

TODO:

  • [ ] FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[2] - UserWarning: Point has no component in this direction. Set ``Computer.relative_size=False`` to avoid this. Using default small step size ``fiddy.EPSILON``: 1e-05
  • [ ] FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[51] - RuntimeWarning: Mean of empty slice
  • [ ] FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[164] - ValueError: cannot reshape array of size 2 into shape (51,2,2)
  • [ ] FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[198] - ValueError: all input arrays must have the same shape
  • [ ] For now, skip gradient checks for all models that require further hyperparameter tuning

dweindl avatar Oct 04 '23 15:10 dweindl