Python splines
This one is to replace #1245. However, it seems like in the long time of divergence, there were changes to functions from sbml_import, that may be not captured, as these functions have been moved out of sbml_import.py to sbml_utils.py on the python_splines branch... It looks like automatic merge of these files did not do completely the right thing... So, we have to be careful about functions that have been moved to newly created files, it seems...
ping @lcontento
Codecov Report
Merging #1515 (71735b6) into develop (81d32e7) will increase coverage by
0.50%. The diff coverage is80.15%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #1515 +/- ##
===========================================
+ Coverage 75.56% 76.06% +0.50%
===========================================
Files 76 80 +4
Lines 13126 14679 +1553
===========================================
+ Hits 9919 11166 +1247
- Misses 3207 3513 +306
| Flag | Coverage Δ | |
|---|---|---|
| cpp | 73.47% <79.65%> (+0.49%) |
:arrow_up: |
| petab | 49.14% <20.69%> (-5.77%) |
:arrow_down: |
| python | 76.79% <80.49%> (+7.92%) |
:arrow_up: |
| sbmlsuite | ∅ <ø> (∅) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| include/amici/abstract_model.h | 0.00% <ø> (ø) |
|
| include/amici/model.h | 56.00% <ø> (ø) |
|
| include/amici/model_state.h | 100.00% <ø> (ø) |
|
| python/sdist/amici/petab_import.py | 69.41% <ø> (ø) |
|
| python/sdist/amici/pysb_import.py | 91.94% <ø> (ø) |
|
| src/spline.cpp | 65.59% <ø> (ø) |
|
| include/amici/splinefunctions.h | 33.33% <33.33%> (ø) |
|
| src/splinefunctions.cpp | 77.22% <77.22%> (ø) |
|
| python/sdist/amici/sbml_import.py | 75.98% <77.77%> (-0.13%) |
:arrow_down: |
| python/sdist/amici/splines.py | 78.90% <78.90%> (ø) |
|
| ... and 5 more |
thanks for pushing this through, code looks like it's in pretty good shape to be approved quickly!










