maxtext icon indicating copy to clipboard operation
maxtext copied to clipboard

[Draft] Add dedicated code owners for codebase

Open RissyRan opened this issue 8 months ago • 1 comments

Description

Add dedicated code owners for codebase for review.

Tests

Expect This CODEOWNERS file is valid check.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • [x] I have performed a self-review of my code.
  • [x] I have necessary comments in my code, particularly in hard-to-understand areas.
  • [x] I have run end-to-end tests tests and provided workload links above if applicable.
  • [x] I have made or will make corresponding changes to the doc if needed.

RissyRan avatar May 06 '25 20:05 RissyRan

I have similar thoughts as above, the idea is reasonable, but in practice might cause more issues than it solves.

patemotter avatar May 06 '25 20:05 patemotter

I have similar thoughts as above, the idea is reasonable, but in practice might cause more issues than it solves.

Yeah, let's see how it goes. It looks like vllm also has this in place. We could change it back if this does not work.

RissyRan avatar May 22 '25 21:05 RissyRan

Talked offline, please add @jrplatin @patemotter @lumosis to inference rules as well.

vipannalla avatar May 22 '25 21:05 vipannalla