agent-protocol icon indicating copy to clipboard operation
agent-protocol copied to clipboard

Kasparpeterson/auth

Open KasparPeterson opened this issue 2 years ago • 2 comments

Pull Request

Description

Introducing the optional authorisation through the header field. See:

  • schemas/openapi.yml
  • schemas/openapi.json

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

  • [X] My code adheres to the project's coding standards and style guidelines.

  • [X] I have tested my changes thoroughly, including unit tests where applicable.

  • [ ] I have updated the documentation to reflect any changes made in this pull request.

  • [X] My branch is up-to-date with the latest changes from the main branch.

  • [ ] I have received code review feedback and addressed any comments or concerns.

Additional Notes

On the main branch the linting is not working using:

  • prettier . -c
  • eslint . --ext .ts,.tsx

Fixed the prettier issue using prettier . -w but could not fix with the eslint as it broke some of the things already fixed with prettier. My conclusion is that these checks are not working at the same time.

References, Fixes and Closes

List any other pull requests or issues that this pull request references, fixes, or closes, if applicable.

  • References #related_issue_number
  • Fixes #related_issue_number
  • Closes #related_issue_number

KasparPeterson avatar Nov 27 '23 13:11 KasparPeterson

Mind fixing the merge conflicts? And remove the reformatting.

hackgoofer avatar Nov 28 '23 18:11 hackgoofer

  1. Need to add RFC
  2. Resolve build errors
  3. Take out style changes to put that in a separate PR.
  4. Update the Doc

cc: @KasparPeterson

hackgoofer avatar Jan 09 '24 17:01 hackgoofer