phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Update to Kotlin 1.6 and enable the new memory model

Open dpad85 opened this issue 3 years ago • 1 comments

This PR updates Phoenix to kotlin 1.6.21. Several dependencies are also updated:

  • lightning-kmp to 1.5+
  • ktor to 2.0.3
  • kotlinx-coroutines to 1.6.3-native-mt
  • kotlinx-datetime to 0.3.2 (transitive from lightning-kmp)
  • (wip) kotlinx-serialization

The Android app is affected and jetpack compose must be updated.

This pull request depends on https://github.com/ACINQ/lightning-kmp/pull/370

dpad85 avatar Sep 22 '22 16:09 dpad85

Latest commit enables the new kotlin Memory Model. For context, see this comment in lightning-kmp repo.

Some more changes are required before this can be merged, especially where we check what thread we're on, or when we use the freeze API (for example SyncTxManager or SqlitePaymentsDb).

Note that we do not upgrade to SQLDelight 2.0.0-alpha03 yet, because that does not seem needed for now.

dpad85 avatar Sep 23 '22 15:09 dpad85