ngx-text-diff icon indicating copy to clipboard operation
ngx-text-diff copied to clipboard

Compare result may change lines ordering?

Open ericxbenoit opened this issue 5 years ago • 11 comments

Hello,

We are using ngx-text-diff in an Angular app and we encountered an issue with the order of the comparison results.

For example, if we have these 5 lines in the left content:

- name: DDD
- name: CCC
- name: BBB
- name: AAA
- name: EEE

And these 5 lines in the right content:

- name: EEE
- name: DDD
- name: AAA
- name: BBB
- name: CCC

The compare result in the right side is:

- name: EEE
- name: DDD
- name: AAA
- name: CCC
- name: BBB

For some unknown reason it inverts the lines BBB and CCC..

Is there a way to fix this problem quickly?

Thanks

ericxbenoit avatar Dec 22 '20 19:12 ericxbenoit

More visual example: NgxTextDiffApp

ericxbenoit avatar Dec 22 '20 20:12 ericxbenoit

Hi,

I have the same problem. Anyone have a suggestion or a quick solution to this problem?

Thanks

jonathan-fortin avatar Dec 23 '20 19:12 jonathan-fortin

Hi, @ericxbenoit and @jonathan-fortin thank you so much for creating the issue. I will try to review it soon and I will push the fix.

ABenassi87 avatar Dec 23 '20 19:12 ABenassi87

@ABenassi87 thanks, your help is really appreciated and I will wait for your fix. Thank you

ericxbenoit avatar Dec 23 '20 19:12 ericxbenoit

Wow, quick reply, thanks @ABenassi87 !

jonathan-fortin avatar Dec 23 '20 19:12 jonathan-fortin

Hi @ABenassi87 do you have any update on this issue ? Do you think it will be possible to have a fixed soon? Thank you!

jonathan-fortin avatar Jan 04 '21 14:01 jonathan-fortin

Hi @jonathan-fortin I'm still working on it. Right now, I hope to have the fix soon.

ABenassi87 avatar Jan 05 '21 14:01 ABenassi87

@ABenassi87 Thanks for the update!

jonathan-fortin avatar Jan 05 '21 19:01 jonathan-fortin

Hello, @ABenassi87 Any update with the fix? Thanks

ericxbenoit avatar Jan 11 '21 16:01 ericxbenoit

Hi @ABenassi87

Your library is amazing, easy to integrate, good UX etc. But, this bug is a blocker in our case. Do you think it will be possible to solve it?

And thank you again for your work!

jonathan-fortin avatar Jan 21 '21 19:01 jonathan-fortin

Hi @ABenassi87,

Hope you are feeling well!

I noticed that you have branched out to resolve this issue. Do you have any idea when you will be releasing a new version with this fix?

Thanks

jonathan-fortin avatar Mar 02 '21 21:03 jonathan-fortin