BBCMicroBot icon indicating copy to clipboard operation
BBCMicroBot copied to clipboard

Revert "wip"

Open ojwb opened this issue 4 years ago • 2 comments

This appears to have been accidentally committed, and breaks the testsuite and normal use.

This reverts commit ed04604ba9e413b9e4ed877706b02be63cf7731d.

ojwb avatar Jun 02 '21 03:06 ojwb

npm test passes locally, but CI fails - apparently because github's CI runner has an ssh key which github doesn't recognise: https://github.com/8bitkick/BBCMicroBot/pull/45/checks?check_run_id=2724350063#step:6:5

It would be useful to resolve this broken wip commit, either by reverting it like I suggest here, or by fixing all the problems with it.

As things currently are it's hard for anyone to contribute because they can't actually run the testsuite or a local instance of the bot, and this is not helped by the widespread changes made by the commit - if it does get reverted anything building on top of it is likely to need adjusting, so if we're going to revert doing it sooner would be better.

ojwb avatar Jun 02 '21 03:06 ojwb

@8bitkick It would be really helpful to sort this out. As things are (and have been for over a year now), nobody can usefully contribute patches, and the code here isn't even usable without patching it (or reverting to before the "wip" commit).

I'd suggest simply dumping in the code that the bot is currently running as an "update to the actual current code" commit would be OK as a solution if you lack the time to do anything else.

ojwb avatar Jul 30 '22 20:07 ojwb

The mastodon branch has working code for the live bot, though it'd probably make sense to just move that to master so the default branch people check out is (a) not broken and (b) gives them the code for the current incarnation of the bot, so I'm going to close this now.

ojwb avatar Nov 27 '22 01:11 ojwb