edge-fs icon indicating copy to clipboard operation
edge-fs copied to clipboard

Project enhancements proposal to support current version of Edge.Js

Open agracio opened this issue 1 year ago • 4 comments

Hi, I maintain an up-to-date version of Edge.Js https://github.com/agracio/edge-js that supports modern versions of Node.Js, .Net Core, incorporates unmerged PRs from original Edge.Js repo and receives constant updates via new PRs and code improvements.

Currently I am looking at migrating various language integrations like edge-fs and others to support .NET core. Since I do not own the original NPM repositories or have maintainer access to them had to resort to forking the projects then renaming newer packages to something similar for example edge-py is published as edge-iron-py which also changes language specification in Edge.Js functions from py to iron-py. Following that example edge-fs would be published as edge-fs-core for .NET Core project while edge-fs would remain as a package for .NET 4.5.

Was wondering if you would be open to the idea of transferring the project to me so I could maintain both .NET Framework and Core versions in one package while adding any necessary improvements.

One way of doing it would be adding me (agracio) as maintainer for edge-fs NPM package and I could publish to it using my forks. If it is done this way then GitHub link would point to my page instead of yours but it would include full credit at the top of the project description, I do not want to take any credit for peoples hard work since I just maintain the existing repo. Currently GitHub link for NPM edge-fs package points to https://github.com/tjanczuk/edge. This has a benefit of offloading any potential issues coming back to this repo as I am sure you have long moved on from this project. Alternatively if you want to resurrect this repo here you could add me as maintainer both on GitHub as well as NPM and publishing would continue from here.

Let me know your thoughts.

agracio avatar Apr 17 '24 14:04 agracio

Hi @7sharp9, did you have a look at it by any chance. I am assuming that you might have muted issues for this ancient project.

I have spoken to Tomasz Janczuk and he agreed to add me as maintainer to his NPM projects as well as the original creator of edge-ps PowerShell module for Edge.js https://github.com/dfinke/edge-ps/issues/8.

agracio avatar Apr 22 '24 16:04 agracio

Hi, sorry about the late reply, I do have all my repos muted so only check messags once in a while. I have added you as maintainer. Theres probably a lot better way of doing the integration as F# has chnaged a little in 11 years, I think the compiler API has opened up a little since then, also a lot more features. Let me know what to do next, archive this repo?

7sharp9 avatar Apr 23 '24 08:04 7sharp9

Hi, thanks for adding me as maintainer. I am not very proficient in F# myself but want to maintain Edge.Js language integrations up to date ensuring compatibility with both .NET Framework and .NET Core. Will be looking at using https://www.nuget.org/packages/FSharp.Compiler.Service/ as an alternative. As for this repo it is entirely up to you what to do with it.

Regarding citing an original creator of the library I opt for README as well as maintaining copyright and package.json files having original author. Here is an example: https://github.com/agracio/edge-sql, let me know if it suits you.

agracio avatar Apr 23 '24 09:04 agracio

Will be looking at using https://www.nuget.org/packages/FSharp.Compiler.Service/ as an alternative.

I was usinng that anyway, maybe it was a little before it got renamed, same thing though. I was originally involved with the creation of FCS.

7sharp9 avatar Apr 23 '24 09:04 7sharp9