git-rstash icon indicating copy to clipboard operation
git-rstash copied to clipboard

import-all() support git submodule and add drop-all() function

Open allenyllee opened this issue 4 years ago • 1 comments

Hi @501st-alpha1 , I come from your stackoverflow anwser, and tries to use your script, it's a great job! But I've encountered some problems, so I try to fix those as below:

  1. import-all() function support git submodule
  2. fix import() function prompt error when its first time stash commit
  3. push() and drop() function use full length SHA instead of short SHA (because I've encounter a problem of different short SHA length between machines)
  4. Also delete local refs/stashes when drop() remote refs/stashes
  5. add drop-all() function

As you say in https://github.com/501st-alpha1/git-rstash/pull/1#issuecomment-842798011, I try to split it into 5 commits. But it can be difficult to separate it into 5 PRs, because every commit is based on previous modification, and the modification is on the same file. If I make each commit as a PR, which all based on your latest commit, when you merge one of those PRs, then merge the other one, it will be conflicted.

Also, separate it into 5 PRs seems takes more effort than just split and commit it sequentially. So I just split it into atomic commit, and still single PR. Tall me if you have other thoughts.

allenyllee avatar May 18 '21 10:05 allenyllee

@501st-alpha1 Any update on when (and if) this PR will be merged?

WrichikBasu avatar Oct 31 '22 12:10 WrichikBasu