OpenMLDB icon indicating copy to clipboard operation
OpenMLDB copied to clipboard

do not use declarations in the global namespace

Open vagetablechicken opened this issue 3 years ago • 2 comments

https://github.com/4paradigm/OpenMLDB/blob/5c06b0ff21199fcd8daf23399248ff39f7b3ff61/src/zk/dist_lock.h#L29-L30

Using declarations in the global namespace in headers are prohibited. Move ThreadPool to openmldb::zk space. using ::openmldb::zk::ZkClient; is useless, remove it.

vagetablechicken avatar Sep 21 '22 04:09 vagetablechicken

Is this issue being worked on? If not, do you want something like this: ::openmldb::zk::ThreadPool; with line 30 removed?

NevilleMthw avatar Sep 21 '22 18:09 NevilleMthw

Is this issue being worked on? If not, do you want something like this: ::openmldb::zk::ThreadPool; with line 30 removed?

Nope, just move line 29 in openmldb::zk space, e.g. move to line 34 https://github.com/4paradigm/OpenMLDB/blob/5c06b0ff21199fcd8daf23399248ff39f7b3ff61/src/zk/dist_lock.h#L32-L34 in the namespace, not the global namespace

vagetablechicken avatar Sep 22 '22 02:09 vagetablechicken