OpenMLDB icon indicating copy to clipboard operation
OpenMLDB copied to clipboard

feat: use list instead of skiplist to store data if `TTLType` is `Latest`

Open longxu0509 opened this issue 3 years ago • 5 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) feature

  • What is the current behavior? (You can also link to an open issue here) https://github.com/4paradigm/OpenMLDB/issues/2007

  • What is the new behavior (if this is a feature change)? add lock-free list and gtest

longxu0509 avatar Sep 02 '22 04:09 longxu0509

Linux Test Report

331 tests   330 :heavy_check_mark:  13m 45s :stopwatch:   51 suites      0 :zzz:   49 files        1 :x:

For more details on these failures, see this check.

Results for commit 0e5f90e0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 02 '22 04:09 github-actions[bot]

Codecov Report

Base: 75.82% // Head: 81.71% // Increases project coverage by +5.89% :tada:

Coverage data is based on head (0e5f90e) compared to base (818b5a1). Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2428       +/-   ##
=============================================
+ Coverage     75.82%   81.71%    +5.89%     
=============================================
  Files           638        8      -630     
  Lines        120497      547   -119950     
  Branches       1053        0     -1053     
=============================================
- Hits          91363      447    -90916     
+ Misses        28919       84    -28835     
+ Partials        215       16      -199     
Impacted Files Coverage Δ
src/base/skiplist.h
src/storage/mem_table.cc
src/storage/mem_table.h
src/storage/record.h
src/storage/segment.cc
src/storage/segment.h
src/storage/segment_test.cc
src/storage/window_iterator.cc
src/storage/window_iterator.h
hybridse/src/codec/fe_row_codec.cc
... and 625 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 02 '22 04:09 codecov[bot]

SDK Test Report

17 files  17 suites   13s :stopwatch: 59 tests 47 :heavy_check_mark: 0 :zzz: 12 :x: 88 runs  74 :heavy_check_mark: 0 :zzz: 14 :x:

For more details on these failures, see this check.

Results for commit 0e5f90e0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 02 '22 05:09 github-actions[bot]

HybridSE Linux Test Report

19 672 tests   19 670 :heavy_check_mark:  6m 51s :stopwatch:      237 suites           2 :zzz:        67 files             0 :x:

Results for commit 0fe01ac0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 02 '22 05:09 github-actions[bot]

HybridSE Mac Test Report

19 672 tests   19 670 :heavy_check_mark:  7m 11s :stopwatch:      237 suites           2 :zzz:        67 files             0 :x:

Results for commit 0fe01ac0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 02 '22 05:09 github-actions[bot]

ok,but i have two quentions

Whether to add license to all three new documents? in src/base/base_iterator.h src/base/concurrentlist.h src/base/concurrentlist_test.cc

Whether the contents of the license are as follows? /*

  • Copyright 2022 4Paradigm
  • Licensed under the Apache License, Version 2.0 (the "License");
  • you may not use this file except in compliance with the License.
  • You may obtain a copy of the License at
  • http://www.apache.org/licenses/LICENSE-2.0
  • Unless required by applicable law or agreed to in writing, software
  • distributed under the License is distributed on an "AS IS" BASIS,
  • WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  • See the License for the specific language governing permissions and
  • limitations under the License. */

thanks

At 2022-10-10 20:16:51, "dl239" @.***> wrote:

@dl239 commented on this pull request.

In src/base/concurrentlist.h:

@@ -0,0 +1,352 @@ +#pragma once

add license

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

longxu0509 avatar Oct 11 '22 00:10 longxu0509