OpenMLDB icon indicating copy to clipboard operation
OpenMLDB copied to clipboard

fix: create with zero partitionnum

Open dl239 opened this issue 3 years ago • 3 comments

  • fix #2217
  • support mutiple distributions https://github.com/4paradigm/OpenMLDB/blob/v0.5.3/hybridse/src/planv2/ast_node_converter.cc#L1680-L1681

dl239 avatar Jul 22 '22 03:07 dl239

Codecov Report

Base: 75.88% // Head: 75.91% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (01a6785) compared to base (6f24627). Patch coverage: 55.67% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2220      +/-   ##
============================================
+ Coverage     75.88%   75.91%   +0.03%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119703   119694       -9     
  Branches       1044     1044              
============================================
+ Hits          90832    90862      +30     
+ Misses        28655    28616      -39     
  Partials        216      216              
Impacted Files Coverage Δ
hybridse/include/node/node_manager.h 100.00% <ø> (ø)
src/storage/mem_table_snapshot.cc 63.46% <0.00%> (ø)
src/sdk/node_adapter.cc 48.46% <22.64%> (-2.07%) :arrow_down:
hybridse/include/node/sql_node.h 83.50% <100.00%> (ø)
hybridse/src/node/node_manager.cc 89.28% <100.00%> (ø)
hybridse/src/node/sql_node.cc 80.11% <100.00%> (ø)
hybridse/src/planv2/ast_node_converter.cc 94.46% <100.00%> (+0.02%) :arrow_up:
hybridse/src/planv2/ast_node_converter_test.cc 95.68% <100.00%> (ø)
hybridse/src/planv2/planner_v2_test.cc 96.06% <100.00%> (ø)
src/cmd/sql_cmd_test.cc 99.00% <100.00%> (+<0.01%) :arrow_up:
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 22 '22 03:07 codecov[bot]

SDK Test Report

  79 files    79 suites   6m 18s :stopwatch: 167 tests 165 :heavy_check_mark: 2 :zzz: 0 :x: 209 runs  207 :heavy_check_mark: 2 :zzz: 0 :x:

Results for commit 01a6785d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 22 '22 04:07 github-actions[bot]

Linux Test Report

       55 files       200 suites   1h 4m 51s :stopwatch:   9 753 tests   9 746 :heavy_check_mark: 7 :zzz: 0 :x: 14 354 runs  14 347 :heavy_check_mark: 7 :zzz: 0 :x:

Results for commit 01a6785d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 22 '22 04:07 github-actions[bot]

HybridSE Linux Test Report

19 672 tests   19 670 :heavy_check_mark:  6m 23s :stopwatch:      237 suites           2 :zzz:        67 files             0 :x:

Results for commit 01a6785d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 31 '22 10:08 github-actions[bot]

HybridSE Mac Test Report

19 672 tests   19 670 :heavy_check_mark:  7m 46s :stopwatch:      237 suites           2 :zzz:        67 files             0 :x:

Results for commit 01a6785d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 31 '22 10:08 github-actions[bot]

pls fix tests in ast_node_converter_test

aceforeverd avatar Sep 01 '22 05:09 aceforeverd