GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

Commit pixi spine bundle

Open f0nar opened this issue 2 years ago • 2 comments

Hi! I didnt create issue before this PR as it is pretty simple change and I think it is better to discuss and solve it here

I see that you keep in repo all files that are required to make runtime work. e.g. threejs, pixi.js, TileMapHelper. In this case tools like https://github.com/arthuro555/gdexporter are possible (I am using it) Unfortunately now spine is not supported with it and that is why I would like to merge pixi spine bundle to repo code

f0nar avatar Feb 12 '24 14:02 f0nar

I think this is more in line with other extensions indeed. Do you need to remove also some script that used to run at npm install?

4ian avatar Feb 13 '24 10:02 4ian

It is up to you. I did not remove it as script might be useful in future if you want to bump spine version. Now it does not affect us at all.

I'll delete it if you say so

f0nar avatar Feb 13 '24 11:02 f0nar

Hi @4ian I update PR

f0nar avatar Mar 03 '24 14:03 f0nar

Looks better! I removed listing of the old file/replaced by the new one were useful. I also did a fix to ensure pixi-spine.js is excluded by TypeScript as it's a pre-built file (https://github.com/4ian/GDevelop/commit/cacd482af9143475cd1b2b81e7365e63b5799896).

Thank you :)

4ian avatar Mar 05 '24 14:03 4ian