github4s icon indicating copy to clipboard operation
github4s copied to clipboard
verified publisher icon 47degrees

patch field being String in FileComparison causing compareCommit to crash

Open rojsrojs opened this issue 3 years ago • 0 comments

Follow up from https://github.com/47degrees/github4s/issues/746.

This is generally not true:

image

I noticed, if a very large change has been made (like 2000 row change of a file), which still has status modified, the patch field won't appear in that case either, which causes JsonParsingError(Invalid message body: Could not decode JSON: {..} error message.

Patch being Option[String] in all scenarios solves this issue.

rojsrojs avatar Feb 18 '22 08:02 rojsrojs