github4s icon indicating copy to clipboard operation
github4s copied to clipboard

Add merge pull request method

Open ploddi opened this issue 4 years ago • 4 comments

Implements https://docs.github.com/en/rest/reference/pulls#merge-a-pull-request

ploddi avatar Jan 13 '22 16:01 ploddi

Reimplements closed #142

ploddi avatar Jan 13 '22 17:01 ploddi

There is no integration test for createPullRequest provided, so it was unclear for me how to correctly implement same test for merge method, that why I skip integration test implementation sorry.

ploddi avatar Jan 15 '22 09:01 ploddi

I can try to implement both tests by committing randomly generated file to test repo.

ploddi avatar Jan 15 '22 09:01 ploddi

The issue is that this will be a bit noisy for watchers of the repo, however I think we can add some unit tests?

BenFradet avatar Jan 17 '22 11:01 BenFradet