bootcamp_machine-learning icon indicating copy to clipboard operation
bootcamp_machine-learning copied to clipboard

ML01 ex05 (z_score): incoherent example

Open mli42 opened this issue 3 years ago • 0 comments

  • Day: 06
  • Exercise: 05

There are 3 minors issues:

Turn in filename

The subject header says: Files to turn in : z_score.py

But the instructions says: In the zscore.py file, write the zscore function (without the underscore)

Undefined numpy

In the examples, X is defined while calling numpy, but Y is defined while calling np

Mismatching Y shape

Still in the examples, Y is declared as follows: Y = np.array([2, 14, -13, 5, 12, 4, -19]).reshape((-1, 1)) Thus its shape is (2, 1) and not (2, ) as X.

The problem is that the expected value is: array([ 0.11267619, 1.16432067, -1.20187941, 0.37558731, 0.98904659, 0.28795027, -1.72770165]) which shape is (7, ), IMO it should be (7, 1) so the zscore function can copy the incomming array's shape.

Fixed on:

  • [ ] Github
  • [ ] Gitlab

mli42 avatar Aug 24 '22 16:08 mli42