APIcast icon indicating copy to clipboard operation
APIcast copied to clipboard

Review and update DNS-resolver doc

Open mayorova opened this issue 3 years ago • 5 comments

The document https://github.com/3scale/APIcast/blob/bcd00e0/doc/dns-resolver.md mentions dnsmasq, howerver dnsmasq is not forming part of the APIcast image anymore, see https://github.com/3scale/APIcast/pull/1090 and https://issues.redhat.com/browse/THREESCALE-1555.

Some other info in the doc might still be relevant though, but it needs to be reviewed and updated according to the current state.

mayorova avatar Aug 24 '22 12:08 mayorova

Hi @mayorova, how about add in docker-compose a dnsmasq container with --add-host pointing to Porta address and use --dns pointing to this new dnsmasq in apicast container?

If this looks good to you, I can add this to the project.

hector-vido avatar Oct 31 '23 01:10 hector-vido

@hector-vido I think the purpose of this ticket is to review and remove dnsmasq from the documentation since we no longer rely on dnsmasq to resolve DNS queries. Therefore, re-adding the dnsmasq container makes no sense to me.

tkan145 avatar Oct 31 '23 02:10 tkan145

@tkan145 sorry, I totally misunderstood and forgot that the containers will relay in docker internal DNS resolver and adding entries in our local /etc/hosts is enough. I was reading it from the perspective of a developer trying to test APICast, but I was wrong any way.

hector-vido avatar Oct 31 '23 03:10 hector-vido

No need to sorry :smiley:

fyi, the resolver logic is located here https://github.com/3scale/APIcast/blob/master/gateway/src/resty/resolver.lua

tkan145 avatar Oct 31 '23 04:10 tkan145

Just FYI, adding entries to /etc/hosts is NOT enough. To run apicast locally in a container, we use a small proxy called porxy to be accessed by IP and relay requests to the porta server with the correct Host header.

akostadinov avatar Jun 11 '24 14:06 akostadinov