github-team-sync icon indicating copy to clipboard operation
github-team-sync copied to clipboard

LDAP_SERVER_PORT currently unused

Open Robbilie opened this issue 3 years ago • 2 comments

LDAP_SERVER_PORT is currently not used and the port and protocol has to be included in the LDAP_SERVER_HOST the PORT env var has to be set though otherwise an error is thrown

https://github.com/github/github-team-sync/issues/124#tasklist-block-1aaf0167-d8f3-4130-b3cc-0ef4cbbf0161

Robbilie avatar May 04 '22 11:05 Robbilie

@Robbilie it looks like we implemented the variables, but only use the LDAP_SERVER_HOST when making the connection. This should be a simple fix. I'll try to get that kicked out this week

primetheus avatar Oct 11 '22 14:10 primetheus

This line is where the server connection is initialized, so we need to incorporate some pre-init logic to build an ldap3.Server instance and use that instead of the environment variable

primetheus avatar Oct 11 '22 14:10 primetheus