manim icon indicating copy to clipboard operation
manim copied to clipboard

add dependency check script

Open Kolloom opened this issue 6 years ago • 8 comments

Just wondering if this is a reasonable approach to check manim dependencies.

Kolloom avatar Jul 16 '19 20:07 Kolloom

This looks like a good start for both a --check-deps option as well as a test suite.

eulertour avatar Jul 16 '19 21:07 eulertour

What is sox for? I did not find any calls to the program. I don't have sox installed on windows and manim seems running fine.

Kolloom avatar Jul 17 '19 05:07 Kolloom

My attempt at obtaining a working virtual machine running macos has not been successful. I will not be implementing the macos portion of the script.

Kolloom avatar Jul 17 '19 17:07 Kolloom

@Kolloom the sox package contains the play binary which is run from manimlib/utils/sounds.py.

eulertour avatar Jul 17 '19 17:07 eulertour

@eulertour seems sox is only used when --sound is set then? This dependency is optional? I haven't seem anyone use the flag in the wild.

Kolloom avatar Jul 17 '19 18:07 Kolloom

@Kolloom yeah it's only optional, it's left over from a long time ago.

eulertour avatar Jul 20 '19 21:07 eulertour

patch ready for review

Kolloom avatar Jul 20 '19 23:07 Kolloom

Can you open a new fork, a couple issues with the code.

k9ur avatar Jul 17 '22 20:07 k9ur