mapsapi icon indicating copy to clipboard operation
mapsapi copied to clipboard

Publish on Bower

Open FluorescentHallucinogen opened this issue 9 years ago • 8 comments

Please create bower.json file and publish this package in Bower registry .

FluorescentHallucinogen avatar Oct 10 '16 18:10 FluorescentHallucinogen

Can you explain how we add the package to bower without built files in the repository?

Trufi avatar Oct 14 '16 09:10 Trufi

Why not add built files into the repo? It's not an anti-pattern anymore.

FluorescentHallucinogen avatar Oct 22 '16 14:10 FluorescentHallucinogen

2gis-maps-react package now available on Bower. But looks like it requires 2gis-maps package. But 2gis-maps is not available on Bower. That's why I've opened this issue.

I'm not sure 2gis-maps-react really requires 2gis-maps, because package.json of 2gis-maps-react doesn't contain "2gis-maps" in "dependencies", but README.md of 2gis-maps-react suggests use npm install 2gis-maps-react 2gis-maps command for installation instead of just npm install 2gis-maps-react. See https://github.com/2gis/2gis-maps-react/issues/7.

FluorescentHallucinogen avatar Oct 22 '16 14:10 FluorescentHallucinogen

BTW, since you use Git tags, if you'll add built files into the repo, you can serve them directly from GitHub with proper Content-Type header using RawGit (https://rawgit.com), a free service based on MaxCDN's (https://maxcdn.com) super fast global CDN. :wink:

And please don't forget to update GitHub releases.

FluorescentHallucinogen avatar Oct 22 '16 15:10 FluorescentHallucinogen

We will not add build files because it creates many merge conflicts and makes code review more difficult.

I think we can look into how https://github.com/Leaflet/Leaflet doing this without built files in the repo.

Trufi avatar Oct 31 '16 03:10 Trufi

Any progress?

FluorescentHallucinogen avatar Nov 18 '16 07:11 FluorescentHallucinogen

Sorry I am a little bit busy right now, but you can create your own pull request

Trufi avatar Nov 18 '16 10:11 Trufi

Should all packages from "dependencies" and "devDependencies" be published on Bower?

FluorescentHallucinogen avatar Nov 25 '16 13:11 FluorescentHallucinogen