spg icon indicating copy to clipboard operation
spg copied to clipboard

Fix tests to use regexp.QuoteMeta instead of \Q ... \E

Open dolmen opened this issue 4 years ago • 3 comments

For maximum safety it is better to use regexp.QuoteMeta instead of wrapping a string with \Q and \E (think about the case where the string ends with \).

dolmen avatar Jan 11 '22 23:01 dolmen

Thank you for this and for your other Pull Requests. They are very much appreciated and will be reviewed. I am just slow.

jpgoldberg avatar Feb 02 '22 16:02 jpgoldberg

@jpgoldberg This a 4 lines patch.

dolmen avatar May 23 '22 11:05 dolmen

@jpgoldberg ping

dolmen avatar Sep 14 '22 15:09 dolmen

Almost one year later and review still didn't happen.

dolmen avatar Jan 05 '23 13:01 dolmen