shell-plugins icon indicating copy to clipboard operation
shell-plugins copied to clipboard

Add support for ipinfo CLI

Open rajapri28613 opened this issue 2 years ago • 3 comments

Overview

Add support for ipinfo CLI. The shell plugin provisions a configuration file at ~/Library/Application\ Support/ipinfo/config.json. The shell plugin also imports the Token from the same file at the same path, if it exists.

Type of change

  • [x] Created a new plugin
  • [ ] Improved an existing plugin
  • [ ] Fixed a bug in an existing plugin
  • [ ] Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install ipinfo CLI and set up shell plugin.
  • Run a bulk query like ipinfo bulk 8.8.8.0-8.8.8.255 1.1.1.0/30 123.123.123.123 and it'll use the token for queries. Bulk queries cannot be run without a token.

Changelog

Add support for ipinfo CLI.

Additional information

rajapri28613 avatar Jul 01 '23 04:07 rajapri28613

Corresponding blog post: https://rajapri28613.hashnode.dev/1password-shell-plugin-for-ipinfo

rajapri28613 avatar Jul 01 '23 06:07 rajapri28613

When I run your test command (ipinfo bulk 8.8.8.0-8.8.8.255 1.1.1.0/30 123.123.123.123) without the shell plugin it works, but after setting up the shell plugin it just hangs. Were you able to get it to run successfully?

accraw avatar Jul 26 '23 18:07 accraw

@rajapri28613 could you share a video of in which this shell plugin is working as expected?

but after setting up the shell plugin it just hangs.

This makes me think that the TempFile approach might not be suitable for this plugin

AndyTitu avatar Aug 30 '23 12:08 AndyTitu