install-cli-action icon indicating copy to clipboard operation
install-cli-action copied to clipboard

Add support for windows runner

Open szzsolt opened this issue 2 years ago • 5 comments

This PR adds support for running the action on windows runners. It includes:

  • powershell script to install op, following the same logic as the original shell script
  • powershell test script modelled after the original bash version
  • changes to the .yml files to run the powershell script when running on windows
  • updated README

szzsolt avatar Oct 26 '23 13:10 szzsolt

It looks like your commits are not signed. A requirement of this repo is to have the commits signed.

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

edif2008 avatar Oct 30 '23 13:10 edif2008

This is really exciting to see! Thank you so much for contributing with this enhancement! 💪🏻

edif2008 avatar Oct 30 '23 14:10 edif2008

@edif2008 @szzsolt I need to run actions on the window as soon as possible. So, can I copy the contents of the PR and sign the commitment to post the PR?😢😢

Jongveloper avatar Dec 11 '23 12:12 Jongveloper

+1

@szzsolt Any chance you will sign your commits?

@Jongveloper Did you manage to find a workaround? Did you re-post the PR with signed commits?

Natiq0 avatar Jun 12 '24 14:06 Natiq0