feat: add Windows support
as the user of the other PR is unresponsive I am creating this PR, I did some small modifications and I am put him as a co-author of the commit as well
⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).
If you're new to commit signing, there are different ways to set it up:
Sign commits with gpg
Follow the steps below to set up commit signing with gpg:
Sign commits with ssh-agent
Follow the steps below to set up commit signing with ssh-agent:
Sign commits with 1Password
You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.
Learn how to use 1Password to sign your commits.
if you could take a look @edif2008 please
Commits are signed
@marcelotrevisani I wonder if the logic from install-cli.ps1 could be simplified by downloading the CLI from winget? We automatically update WinGet with each cli version we release (for stable only). Maybe if we use a winget-cli download action, we could then simply do winget install 1password-cli
Hi, I might be wrong but I think winget is not available by default in the windows GitHub runners. And this current solution is more generic. That would simplify the logic but will add a new step to guarantee that winget is installed. Because self hosted runners might not have it as well
Gentle ping @AndyTitu
Sorry for pinging but that is blocking us to use 1password with gh actions and we dont want to have one setup for windows and another for unix-like OS.
@AndyTitu ?
cc @SimonBarendse
@marcelotrevisani Thank you for your contribution ❤️ We really appreciate the effort you put into adding Windows support.
After reviewing the feature in more detail, we decided to move forward with a TypeScript-based implementation to improve cross-platform support and maintainability.
You can check out the implementation here: #16
Thanks again for your work! 🙌