connect-sdk-python icon indicating copy to clipboard operation
connect-sdk-python copied to clipboard

Wrong return type hint for load_dict

Open kthy opened this issue 2 years ago • 1 comments

  • SDK Version: 1.3.0
  • Connect Server Version: 1.6.0
  • OS: ubuntu-22.04
  • Python Version: 3.10

What happened?

The type hint for the return value of load_dict is Dict[str, str] (as stated in config.py line 60) but the actual return type is dict[str, str | None], or dict[str, Optional[str]] if you prefer.

How to reproduce

Add a text field with no value to an item in 1Password. It will not be shown in the client, but when you click Edit you can see it is still there; you can also verify this with e.g. curl.

Then call load_dict and you will see that the value of the field is None.

kthy avatar Feb 14 '23 14:02 kthy

Hi @kthy👋. Thank you very much for reporting this! We're going to take a look and fix that.

volodymyrZotov avatar Mar 01 '23 15:03 volodymyrZotov