10up
Add --include_files --include_db flags
Include the --include_files --include_db flags in the wpsnapshots pull call.
Description of the Change
Without those, the command will wait for a user input that will never come.
This is blocking the WPAcceptance test on CI because wpsnapshots in the docker image has been updated to the latest version.
@tlovett1 Please consider merging this PR and update the wpacceptance docker image so we can continue running WPA for 10up's open-source plugins. Currently, WPA tests of plugins using snapshots are failing because the pull command requires passing all arguments.
Applying this PR, @thrijith found another issue while working on the A11y Checkup plugin, which I can reproduce on my end.
Warning: rmdir(/root/.wpsnapshots/a3f2959614a18989ea365da4d86945f1/): Device or resource busy in /root/.composer/vendor/10up/wpsnapshots/src/utils.php on line 359
SSH into the container, I got the same error trying to delete the folder manually:
root@d4165de11326:~/.wpsnapshots# rm -rf a3f2959614a18989ea365da4d86945f1/
rm: cannot remove 'a3f2959614a18989ea365da4d86945f1/': Device or resource busy
This issue only happens inside wpa container, I can pull with --overwrite_local_copy on the host machine flawlessly.
IMO, the best way to solve this issue is allowing bypass --overwrite_local_copy. Currently, that flag doesn't accept any value, so there is no way to skip overwriting the local snapshot inside WPA docker container.
I created a PR to fix the overwriting local snapshot issue: https://github.com/10up/wpsnapshots/pull/86.
@felipeelia After the 86 is merged, can you please revert the change in https://github.com/10up/wpacceptance/pull/34/commits/fdbdf8dba2633e1388dc525eab8cfe7e52ae0d75?