wp_mock icon indicating copy to clipboard operation
wp_mock copied to clipboard

PHPCS reporting error on dependent library nikic/php-parser, hamcrest/hamcrest-php

Open sfgourav opened this issue 1 year ago • 1 comments

Bug report

  • Need update of dependent libraries to support php 8.2+

Replication steps

  • If we run phpcs on the repo we see the following errors Screenshot 2024-09-02 at 12 30 37 PM Screenshot 2024-09-02 at 12 30 21 PM

Expected behavior

  • support for dependent libraries for php8.2+

sfgourav avatar Sep 02 '24 07:09 sfgourav

Thanks @sfgourav for reporting this potential issue with php 8.2. according to composer.lock WP_Mock using the latest release version of hamcrest/hamcrest-php package https://github.com/hamcrest/hamcrest-php/releases/tag/v2.0.1 which it about 4 years old. But as far as I can tell the hex value is still valid, don't you think?

FYI: I found there is an issue already open for that error => https://github.com/hamcrest/hamcrest-php/issues/78

nmolham-godaddy avatar Sep 02 '24 23:09 nmolham-godaddy