wp-component-library icon indicating copy to clipboard operation
wp-component-library copied to clipboard

Component/vetting tiny slider

Open treighton opened this issue 6 years ago • 3 comments

Description of the Change

Adding a page for Tiny Slider based on a review to confirm compliance with WCAG 2.1AA

Alternate Designs

I'm not sure that this applies, but the slider was tested in multiple scenarios, manually, in addition to analyzing http://ganlanyuan.github.io/tiny-slider/demo/ (this page is not very accessible), to ensure that there are ways to use the slider accessibly.

Benefits

We will now have an approved slider

Possible Drawbacks

It is still possible to use the slider in an inaccessible way.

This may not be the best solution for use with react since it manipulates the DOM directly.

Verification Process

In order to verify that the slider is accessible, I built a few fake pages that had different instances of the slider in different use cases.

I build one that had just a few slides that were just images, another that had images and text, and another that had links. I tested all of these with controls, and on both autoplay and non-autoplay.

In order to check compliance, I used a combination of Lighthouse accessibility audit, Axe accessibility audit, and manually checking against the WCAG2.1 guidelines https://www.w3.org/TR/WCAG21/ using windows narrator, Mac OS Voiceover, and NVDA screen reader, and manually navigating the pages with only the keyboard.

Checklist:

  • [ x] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] All new and existing tests passed.

Applicable Issues

treighton avatar Jan 30 '20 03:01 treighton

@treighton any updates from @timwright12's feedback?

jeffpaul avatar Jul 14 '20 04:07 jeffpaul

@jeffpaul I haven't had time to get back into this lately. If i need to bump this up in priority let me know so i can move things around.

treighton avatar Jul 14 '20 18:07 treighton

@timwright12 I'll defer to you on optimal timeline.

jeffpaul avatar Jul 14 '20 19:07 jeffpaul