generator-wp-make icon indicating copy to clipboard operation
generator-wp-make copied to clipboard

New eslint recommendation

Open timwright12 opened this issue 8 years ago • 1 comments

Chatting with @eugene-manuilov about the eslint we're generating. I'd like to open up the discussion for something like:

    "env": {
        "browser": true
    },
    "extends": "airbnb",
    "rules": {
        "indent": [2, "tab", {"SwitchCase": 1}],
        "no-undefined": [0],
        "linebreak-style": [1, "unix"],
        "quotes": [2, "single"],
        "semi": [2, "always"],
        "space-in-parens": [2, "always"],
        "no-console": [1],
        "no-alert": [1],
        "camelcase": [2],
    },
    "globals": {
        "TenUp": true,
    }
}```

Balancing the 10up standards with the more ES6-focused Airbnb config

timwright12 avatar Aug 29 '17 15:08 timwright12

I'd like to add on to this that running grunt fails eslint immediately on the current version of WP Make, so some changes to the default file or the lint rules are needed here as well.

harrisonfm avatar Oct 31 '17 19:10 harrisonfm