distributor icon indicating copy to clipboard operation
distributor copied to clipboard
verified publisher icon 10up

Fix: i18n po/mo not loaded

Open dinhtungdu opened this issue 5 years ago • 5 comments

Description of the Change

This PR loads textdomain properly, allowing distributor to ship translations with future release. Props @sebastienserre for reporting this.

Verification Process

See #660

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [ ] All new and existing tests passed.

Applicable Issues

Fixes #660

Changelog Entry

dinhtungdu avatar Nov 02 '20 10:11 dinhtungdu

@dinhtungdu will want to make sure we confirm the checklist items on #267 for this PR.

jeffpaul avatar Nov 02 '20 19:11 jeffpaul

@jeffpaul @dinhtungdu Left a comment on the PR but leaving it here as well. This PR loads a textdomain but doesn't actually add the lang directory (or add any translations). I understand this is just a single step in the right direction and actual translations can come later but I think we might want to add the lang directory as part of this PR, so it's there and ready to drop translations into.

dkotter avatar Dec 09 '20 17:12 dkotter

I believe the lang directory and POT file get built into the stable branch as part of the release action, but maybe that's worth having in develop and trunk as well? Will defer to @helen, though may just be worth punting this if there's any discussion needed so as to not hold up the 1.6.2 release.

jeffpaul avatar Dec 09 '20 17:12 jeffpaul

I believe the lang directory and POT file get built into the stable branch as part of the release action, but maybe that's worth having in develop and trunk as well? Will defer to @helen, though may just be worth punting this if there's any discussion needed so as to not hold up the 1.6.2 release.

Ah, that makes sense. But yeah, does bring up the point of how do people submit a PR with language files if there isn't a lang directory to put those files in (which was brought up on #660)

I'm fine with this PR but there's definitely more work around translations that needs done, so could argue for waiting on this until we have the other parts in place.

dkotter avatar Dec 09 '20 17:12 dkotter

I'm going to punt to 1.7.0 to give us time to chat about if/how we want to handle MO/PO files and other topics related to translations.

jeffpaul avatar Dec 09 '20 17:12 jeffpaul

This was resolved in e6f1dd37194b7276d53b37e5a21d3a68fdb01fb2 for another PR, so closing this off.

peterwilsoncc avatar Mar 27 '23 22:03 peterwilsoncc