distributor icon indicating copy to clipboard operation
distributor copied to clipboard

Add hooks in push actions

Open avag-novembit opened this issue 6 years ago • 8 comments

Makes possible to run post distribution and re-distribution in background, closes #416.

avag-novembit avatar Jun 24 '19 17:06 avag-novembit

Hi @avag-novembit, thank you for your contribution.

Looking at the code, if the user returns true from dt_push_allow_in_background, normal 'push' behavior is bypassed. I don't see code to handle actually pushing the content here, are you working on that separately?

If we are going to enable async push requests, we probably want to include full support for the actual pushing as well, and proper UI to show the (background) progress.

adamsilverstein avatar Jul 08 '19 15:07 adamsilverstein

Hi @avag-novembit, thank you for your contribution.

Looking at the code, if the user returns true from dt_push_allow_in_background, normal 'push' behavior is bypassed. I don't see code to handle actually pushing the content here, are you working on that separately?

If we are going to enable async push requests, we probably want to include full support for the actual pushing as well, and proper UI to show the (background) progress.

Hi @adamsilverstein, thanks for the comments.

Yes, 'Push in background' implementation is planned to be a separate add-on, and it will have its UI. Currently working on it.

avag-novembit avatar Jul 09 '19 08:07 avag-novembit

@avag-novembit Thanks for your updates here. I left some additional feedback. I'm still not 100% clear on your use case and whether its something the code plugin should support directly, enable via filters or perhaps help you figure out how to implement using existing extensibility.

When you have code ready that is close or complete, can you link to your project so we can better evaluate the value of these changes. Thanks!

adamsilverstein avatar Jul 15 '19 20:07 adamsilverstein

@adamsilverstein thanks. Hope my last comments gives some idea how filters can be used.

avag-novembit avatar Jul 17 '19 12:07 avag-novembit

@avag-novembit we're looking to solve a similar issue related to reports on ACF issues as part of our 2.1.0 release so I'm moving this PR and related issue to that release as well.

jeffpaul avatar Mar 26 '20 13:03 jeffpaul

Unassigning reviewers here while we focus on the v2 refactoring and can then reassess how best to handle the root issue here.

jeffpaul avatar Jan 16 '23 18:01 jeffpaul

@jeffpaul we are maintaining this repo anymor, however, if you will decide to move forward, please let me know if we will review it on our end.

arsendovlatyan avatar Jan 17 '23 13:01 arsendovlatyan

@avag-novembit thanks for the PR! Could you please rebase your PR on top of the latest changes in the base branch?

github-actions[bot] avatar Feb 09 '24 15:02 github-actions[bot]