convert-to-blocks icon indicating copy to clipboard operation
convert-to-blocks copied to clipboard
verified publisher icon 10up

Bumped WP and PHP Minimums

Open zamanq opened this issue 3 years ago • 1 comments

Description of the Change

Bumped up WordPress PHP minimums. Closes #73

Changelog Entry

Added - Bumped up WordPress and PHP Minimum Requirements

Credits

Props @jeffpaul @zamanq

Checklist:

  • [x] I agree to follow this project's Code of Conduct.
  • [x] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [ ] All new and existing tests pass.

zamanq avatar Oct 07 '22 17:10 zamanq

@zamanq I've approved the PR but I've just noticed that the phpunit and phpcs tests are failing. Can you please check them?

faisal-alvi avatar Oct 10 '22 11:10 faisal-alvi

Noting that if anyone is able to help with the test failures here that would help move this PR along, thanks!

jeffpaul avatar Oct 27 '22 13:10 jeffpaul

@jeffpaul I have resolved the merge conflicts and updated code to ensure the tests doesn't fail due to the update in PHP version. Also, to mention that the PHPCS tests are failing due to a known bug (https://github.com/WordPress/WordPress-Coding-Standards/issues/2035) in WPCS. So, I have added a temporary work around to that until they release a new version of WPCS.

mehul0810 avatar Jan 05 '23 05:01 mehul0810