action-wordpress-plugin-deploy icon indicating copy to clipboard operation
action-wordpress-plugin-deploy copied to clipboard

questions regarding the build process

Open mtoensing opened this issue 3 years ago • 1 comments

Hi! Thank you very much for this GitHub action! This streamlined my process to deploy my SimpleTOC Plug-In: https://github.com/mtoensing/simpletoc/blob/master/.github/workflows/deploy.yml

I use the "build" feature and have a few questions. When I use

Run npm install @wordpress/scripts --save-dev

I get these warnings and the process pauses for a few seconds. Is this normal and intended? Can I remove the warnings somehow?

Run npm install @wordpress/scripts --save-dev
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN   peer react@">=16.8.0" from @emotion/[email protected]
npm WARN   node_modules/@emotion/react
npm WARN     peer @emotion/react@"^11.0.0-rc.0" from @emotion/[email protected]
npm WARN     node_modules/@emotion/styled
npm WARN     1 more (@wordpress/components)
npm WARN   30 more (@emotion/styled, @floating-ui/react-dom, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^0.14 || ^[15](https://github.com/mtoensing/simpletoc/runs/7794469494?check_suite_focus=true#step:3:16).5.4 || ^16.1.1" from [email protected]
npm WARN node_modules/react-dates
npm WARN   react-dates@"^21.8.0" from @wordpress/[email protected]
npm WARN   node_modules/@wordpress/components
npm WARN 
npm WARN Conflicting peer dependency: react@[16](https://github.com/mtoensing/simpletoc/runs/7794469494?check_suite_focus=true#step:3:17).14.0 ....

My other question is: Is the build process just for validation, or is it used for the commit to svn? So if I use "npm start" locally will the resulting JavaScript be used or the compiled script from your action?

Thank you! =)

mtoensing avatar Aug 11 '22 20:08 mtoensing

Hi, @mtoensing this might be a mismatch of node versions causing the local node version and GitHub action node version. You can look at this Node action and add this block action before your build process.

Here is a sample.

      - name: Use Node.js 12.1.0
        uses: actions/setup-node@v4
        with:
          node-version: 12.1.0

iftakharul-islam avatar Feb 10 '25 14:02 iftakharul-islam