WP-Minions icon indicating copy to clipboard operation
WP-Minions copied to clipboard

Allow either the 1.x or 2.x branch of composer installers

Open johnpbloch opened this issue 4 years ago • 0 comments

Description of the Change

This change adds the 2.x branch to the versions that will satisfy the composer installers dependency. wpackagist already does this. Currently this plugin is blocking my ability to upgrade the installers package.

Alternate Designs

N/A

Benefits

The ability to update application code.

Possible Drawbacks

None.

Verification Process

composer update still works.

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [ ] All new and existing tests passed.

Regarding the last checkpoint: updating the tests to run on modern versions of PHP is something that would be worthwhile in the future, but is out of scope for this PR. This change does not make any changes that affect the PHP behavior of this plugin, so it should not be a concern regarding this PR specifically that I was unable to run the test suite.

Applicable Issues

N/A

Changelog Entry

N/A

johnpbloch avatar Dec 07 '21 22:12 johnpbloch