Engineering-Best-Practices

Engineering-Best-Practices copied to clipboard

michael-sumner

Use of filter_input()

10

I've used Code Climate for several personal projects and something that is recommended frequently is using filter_input() rather than accessing $_POST and $_GET directly. I didn't see anything in our...

petenelson

[JavaScript] Avoid using aliases (such as webpack alias) in favor of relative imports

2

**Is your enhancement related to a problem? Please describe.** Webpack aliases (and similar features in other bundles) often cause more harm than good. With alias we can convert imports like...

nicholasio

Add React to main nav and homepage

1

timwright12

Included third parameter for in_array example to adhere to the guide in the next section (https://10up.github.io/Engineering-Best-Practices/php/#build-arrays-that-encourage-lookup-by-key-instead-of-search-by-value): _"In case you don't have control over the array creation process and are forced...

zutigrm

### Describe the bug In the migration documentation it says: > Use PHP7 > If PHP 7 is an option, use it. This should either be upped to PHP 8,...

PypWalters

Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. Commits 699c459 3.1.2 2f2b5ff fix: trim pattern 25d7c0d 3.1.1 55dda29 fix: treat nocase:true as always having magic 5e1fb8d 3.1.0 f8145c5 Add 'allowWindowsEscape' option 570e8b1...

dependabot[bot]

### Is your enhancement related to a problem? Please describe. There are a few typos that will need updating in the docs as well as updating non-evergreen content related to...

michael-sumner

michael-sumner

### Description of the Change The links to eslint and babel-preset were pointing at archived repos. This PR updates these links. - Update eslint link to: https://github.com/10up/10up-toolkit/tree/develop/packages/eslint-config - Update babel-preset...

scottlee