MorePartsMod icon indicating copy to clipboard operation
MorePartsMod copied to clipboard

Bug: Refueling bug

Open idkwhy-cyber opened this issue 10 months ago • 3 comments

Describe the bug Refueling doesn't work when landing on a colony even though i am well withing 100m of the Refinery

To Reproduce Steps to reproduce the behavior:

  1. Make a colony
  2. Build a Refinery
  3. Land a rocket near it
  4. Result: no refueling

Additional context The inability to refuel may have something to do with the fact that my fuel isn't at absolute zero since in your code it uses this if statement

if (this._rocketTanks == null)
{
    this._rocketTanks = this.GetRocketTanks();
    return;
}

I am not a programmer but have dabbled slightly in C# and it looks to me like this only lets the rocket refill if the tanks are at 0. My tanks are not at 0 which may be what stops me from refueling but I will try and see if it will refuel my rocket if i turn the fuel level to 0 and post results below

idkwhy-cyber avatar Mar 08 '25 16:03 idkwhy-cyber

In vanilla SFS you can dock 2 or more "rockets" and refuel like that. Click the fueled rocket and the empty rocket in that order to start refueling regularly.

Penguin4241 avatar Mar 11 '25 00:03 Penguin4241

I think there is a bug the first time you create the refinery and want to start refueling rockets, just exit the world and re-enter, it should work.

dani0105 avatar Mar 31 '25 18:03 dani0105

Additional context The inability to refuel may have something to do with the fact that my fuel isn't at absolute zero since in your code it uses this if statement

if (this._rocketTanks == null)
{
    this._rocketTanks = this.GetRocketTanks();
    return;
}

_rocketTanks doesn't detect whether the rocket is full or empty, it only checks if it has tanks on its structure. I think the problem is Rocket has a null value, because the refinery was recently created. Reloading the world should fix the problem.

dani0105 avatar Mar 31 '25 18:03 dani0105