sequence.js icon indicating copy to clipboard operation
sequence.js copied to clipboard

Add prefix for EIP-191 signature before hashing

Open PhABC opened this issue 3 years ago • 1 comments

Allows Sequence wallet to login on Opensea among other dapps.

PhABC avatar Apr 05 '22 19:04 PhABC

Codecov Report

Merging #249 (066edc2) into master (56030e9) will decrease coverage by 0.63%. The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   38.46%   37.83%   -0.64%     
==========================================
  Files         131      131              
  Lines        4854     4824      -30     
  Branches     1015     1008       -7     
==========================================
- Hits         1867     1825      -42     
- Misses       2731     2746      +15     
+ Partials      256      253       -3     
Impacted Files Coverage Δ
packages/provider/src/utils.ts 34.92% <0.00%> (ø)
packages/provider/src/utils/index.ts 13.88% <0.00%> (ø)
packages/wallet/src/utils.ts 35.29% <ø> (ø)
packages/wallet/src/wallet.ts 62.50% <75.00%> (-0.74%) :arrow_down:
packages/utils/src/digest.ts 100.00% <100.00%> (+33.33%) :arrow_up:
...ges/multicall/src/providers/provider-middleware.ts 42.85% <0.00%> (-28.58%) :arrow_down:
packages/multicall/src/multicall.ts 47.14% <0.00%> (-12.36%) :arrow_down:
packages/multicall/src/utils.ts 34.61% <0.00%> (-11.54%) :arrow_down:
...kages/multicall/src/providers/external-provider.ts 41.17% <0.00%> (-11.00%) :arrow_down:
packages/multicall/src/providers/provider.ts 72.34% <0.00%> (-3.53%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56030e9...066edc2. Read the comment docs.

codecov-commenter avatar Apr 06 '22 15:04 codecov-commenter