0x-api icon indicating copy to clipboard operation
0x-api copied to clipboard

feat: added lastLookConfig to transaction entity

Open alexkroeger opened this issue 4 years ago • 1 comments

Description

For RFQM the transaction worker will have to know to ping the market maker before submission. The details of how to do so are stored in lastLookConfig.

Testing Instructions

Checklist

  • [ ] Update documentation as needed. Website Documentation PR:

  • [ ] Prefix PR title with [WIP] if necessary.

  • [ ] Add tests to cover changes as needed.

  • [ ] Test changes on the staging environment with Matcha API Staging.

    • [ ] SRA/Limit orders
    • [ ] Swap endpoints
    • [ ] Meta transaction endpoints
    • [ ] Depth charts

    For more information see 0x API Matcha smoke test runbook in Quip.

alexkroeger avatar Mar 26 '21 00:03 alexkroeger

  • Do we need to add a new status field on the table itself (not json) that allows us to determine if an order is pending, rejected by a MM, or complete?
  • Do we need to also have a field order_hash alongside tx_hash? it looks like we would use both fields to retreive an order

There is already a status field to determine where in the lifecycle the tx is. There is an enum type for it, I added an option for lastLookRejected, which will end the submission process. order_hash shouldn't be necessary to track in a separate field. It's in the lastLookConfig if we want to expose it.

alexkroeger avatar Mar 31 '21 17:03 alexkroeger