isolate-package icon indicating copy to clipboard operation
isolate-package copied to clipboard

copy patches with pnpm

Open kevpie opened this issue 4 months ago • 1 comments

Copies the relevant patches to the isolate folder along with package.json section.

Probably a better way to do this. For now I force firebase-tools-with-isolate to provide the right config using a patch like this.

diff --git a/lib/deploy/functions/prepareFunctionsUpload.js b/lib/deploy/functions/prepareFunctionsUpload.js
index f6cf911cd7d67983e57b50aa05a8289d4da6484b..b417d22524588ffb93fe221dae49590de9b762b4 100644
--- a/lib/deploy/functions/prepareFunctionsUpload.js
+++ b/lib/deploy/functions/prepareFunctionsUpload.js
@@ -99,9 +99,12 @@ async function runIsolate(sourceDirName) {
     try {
         utils.logLabeledBullet("isolate", `Isolating the source`);
         const { isolate } = (await (0, dynamicImport_1.dynamicImport)("isolate-package"));
+        console.log("isolateDir!!", sourceDirName);
         const isolateDir = await isolate(sourceDirName !== "."
             ? {
                 targetPackagePath: path.join("./", sourceDirName),
+                includePatchedDependencies: true,
+                workspaceRoot: "..",
             }
             : undefined);
         utils.logLabeledBullet("isolate", `Finished isolation at ${clc.bold(isolateDir)}`);

kevpie avatar Sep 25 '25 06:09 kevpie

I wish this feature would be released soon!

jieey1140 avatar Nov 06 '25 09:11 jieey1140