GraphQLSP icon indicating copy to clipboard operation
GraphQLSP copied to clipboard

Language server suggestions are too aggressive with dots

Open zkulbeda opened this issue 1 year ago • 2 comments

Describe the bug

I want to use a fragment and I need to write down 3 dots before fragment name. But in vscode this is happening:

tada

So I have to press esc button after every dot to close the suggection dropdown. I'm using vscode with default settings.

PS: Thank you for such an awesome library!

Reproduction

No response

gql.tada version

1.3.5

Validations

  • [X] I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
  • [X] Read the docs.
  • [X] Follow our Code of Conduct

zkulbeda avatar Mar 16 '24 21:03 zkulbeda

That's not really the Language server being too aggressive, it's a setting in VSCode 😅 I guess an alternative suggestion here would be to always display the fragment-spread option but when there's a lot of field that might not be a good option either

JoviDeCroock avatar Mar 17 '24 08:03 JoviDeCroock

The thing is that this issue doesn't happen when using the spread operator in plain JavaScript or Typescript (without regards to the aforementioned VS Code setting). In the latter case, the suggestions ONLY show up after the third dot is typed, whereas with GraphQLSP the suggestions start showing up right after the first dot is typed.

Maximaximum avatar Apr 25 '24 11:04 Maximaximum